Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*): correct mistakes in word #12

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

yariksav
Copy link

No description provided.

@coveralls
Copy link

coveralls commented Jun 20, 2018

Pull Request Test Coverage Report for Build 34

  • 2 of 6 (33.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.0%) to 91.534%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Persona.js 2 6 33.33%
Totals Coverage Status
Change from base Build 33: -2.0%
Covered Lines: 136
Relevant Lines: 145

💛 - Coveralls

@RomainLanz
Copy link
Member

Nice!

I believe we can release it as a breaking change update but since it's not critical we can wait a little bit.

@thetutlage
Copy link
Member

Also we can add a depreciation notice to the existing method and then remove it later in the next major release.

@thetutlage
Copy link
Member

@yariksav Lemme know if you need any guidance

@yariksav
Copy link
Author

I've added deprecation methods, and fixed one more mistake in massageRegisterationData

@thetutlage
Copy link
Member

thetutlage commented Jun 25, 2018

massageRegistrationData is not a mistake.

You have change massage to message whereas massage itself is a word and used intentionally

@yariksav
Copy link
Author

@thetutlage, sorry, it misunderstanding, I've fixed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants