AG 11450 - Remove use of Charts autoSize. #7979
Conversation
| @@ -648,126 +648,6 @@ exports[`chartModelMigration upgradeChartModel should upgrade 22.1.0-doughnut-ca | |||
| } | |||
| `; | |||
|
|
|||
| exports[`chartModelMigration upgradeChartModel should upgrade 22.1.0-doughnut-callout successfully 1`] = ` | |||
There was a problem hiding this comment.
Note: Not sure why, but this was a redundant duplicate (see previous snapshot) - nx test @ag-grid-enterprise/charts -u removed it correctly.
| common.minHeight = 0; | ||
| common.minWidth = 0; |
There was a problem hiding this comment.
These are needed to match previous behaviour, and should ensure full backwards compatibility.
There were about 3 examples which showed layout issues without this change due to the popup / container HTML element being smaller than the 'safe' OOB defaults we've added, as a cross-check that this is working.
| parent['minHeight'] = 600; | ||
| parent['minWidth'] = 300; |
There was a problem hiding this comment.
This is a bit of an odd case, if anyone was setting autoSize: false before then I'm pretty sure the layout would have been borked, unless they also set width and height - if they were falling into that case, this mutation should yield no difference.
https://ag-grid.atlassian.net/browse/AG-11450
The Charts
autoSizeoption is being removed for the 10.0.0 release - these updates should maintain backwards compatibility from a Grid perspective 🤞