added user service to Dockerfile so it run as non-root user #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meonkeys
reviewed
May 9, 2024
| @@ -1,6 +1,8 @@ | |||
| FROM swaggerapi/swagger-ui:v5.9.1 AS swagger-ui | |||
| FROM python:3.10-slim | |||
|
|
|||
| RUN useradd -m service | |||
There was a problem hiding this comment.
This maps to an arbitrary user id that may or may not exist on the Docker host, right? So if you want asr to, for example, cache models in mounted volumes (mounted to host folders), those folders on the host would need to be owned by the same user id and have proper permissions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the necessary modifications to the Dockerfile to ensure that the application runs as a non-root user. The changes include the creation of a non-privileged user, setting appropriate permissions, and adjusting the Dockerfile accordingly.