-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font ligatures #3731
Font ligatures #3731
Conversation
…EHOLDER_GLYPH to 0 (from 1).
…ph_iter to be more flexible.
…g logic to text run draw loop in display
… of RenderableCells, allocate a Vec of TextRun instead.
This implements --hold flag which keeps Alacritty open after its child process exits. Fixes #1165.
On X11 `swap_buffers` does not block for vsync. However the next OpenGl command will block to synchronize (this is `glClear` in Alacritty), which causes a permanent one frame delay. Calling `glFinish` after swapping buffers forces Alacritty to finish the buffer swap before returning control to the event loop. Fixes #3061.
Instead of blocking on vsync, Alacritty now requests a notification from wayland about when the next frame should be rendered. this helps with input latency, since it gives alacritty more time to process events before a redraw. it also prevents alacritty from drawing unless the compositor tells it to do so. Fixes #2851.
This resolves an issue with the ScrollToBottom motion in vi mode where it would jump between the first unoccupied cell across wrapped lines and the first unoccupied cell in the current line.
The comment does not state that all that needs to be done is for this to be rebased on top of master. That's just the first thing that needs to be done before resolving all the other problems. This is the second PR now which just rebases the original PR likely introducing a bunch of regressions without ever producing even a working build. So I'd strongly recommend for anyone who is actually interested in putting in the work to implement it, to make sure their work at least builds before sending a PR. This is not an easy issue and you should be very familiar with the existing code before attacking the remaining issues. If you're not willing or capable to put in that time, then please just wait until someone else comes around who is. |
Hello everyone,
I've never written rust before in my life, so I have no idea what I am doing here.
I've seen this comment on this issue about this branch that just needed to be rebased against the repo's master and thought I could help out by doing so.
I've just rebased this branch into my master that I've just forked out of alacritty's official repo.
I'm stepping out to run a few errands but feel free to pitch in and give feedback on the work done so far (Huge shout out to thunderseethe for kicking off (and highly likely wrapping up the work in here).
fixes #50