Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pty's pixelsize being zero until resize #7822

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Conversation

kchibisov
Copy link
Member

117719b removed the extra call for TIOCSWINSZ, however the first call was not setting the pixelsize for unknown reason, which regressed some clients.

Fixes: 117719b (Remove extra TIOCSWINSZ)

--

It was like that since the start of alacritty, and then it was just carried. The second call to resize the PTY just masked the issue.

117719b removed the extra call for TIOCSWINSZ, however the first call
was not setting the pixelsize for _unknown_ reason, which regressed
some clients.

Fixes: 117719b (Remove extra TIOCSWINSZ)
@kchibisov kchibisov added this to the Version 0.13.2 milestone Mar 9, 2024
Copy link
Member

@chrisduerr chrisduerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unknown reason

It's not an unknown reason. ws_xpixel and ws_ypixel are unused according to kernel documentation.

Which application is relying on these?

@kchibisov
Copy link
Member Author

It's not an unknown reason. ws_xpixel and ws_ypixel are unused according to kernel documentation.

#4763 (comment)

We also set it via on_resize so we should either never set it or we should always set it.

Right now we don't set it for create, but we set it later, and it was also always set before, so don't see why we shouldn't stick to behavior we had.

Copy link
Member

@chrisduerr chrisduerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose there's no reason not to set it if we have the information, even if it shouldn't be used. It's also just simpler, which is nice.

@chrisduerr chrisduerr merged commit 41d2f1d into master Mar 9, 2024
8 checks passed
@chrisduerr chrisduerr deleted the not-reset-pixel branch March 9, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants