Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support terminal-wg's BiDi draft proposal in alacritty_terminal #7872

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Apr 9, 2024

  1. Support terminal-wg's BiDi draft proposal in alacritty_terminal

    https://terminal-wg.pages.freedesktop.org/bidi
    
    Implementation is hidden behind a `bidi_draft` crate feature, and
    depends on alacritty/vte#112.
    
    Public API is limited to:
     * `Cell::bidi_mode()` method which returns a `BidiMode` enum value.
     * `Cell::bidi_box_mirroring()` method which returns a boolean.
     * `Term` boolean field `bidi_disable_arrow_key_swapping`.
    
    Cell `BidiFlags` is only used internally since relations/interactions
    between individual flags are not straight forward, and could lead to
    erroneous behavior if it's all left for API consumers to figure out.
    
    `BidiDir` named fields exist in all `BidiMode` variants. This is done
    deliberately (instead of e.g. a `BidiMode` struct with a `BidiDir` field)
    to signify the different purpose `BidiDir` serves in each mode.
    
    Signed-off-by: Mohammad AlSaleh <CE.Mohammad.AlSaleh@gmail.com>
    MoSal committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    2295953 View commit details
    Browse the repository at this point in the history