Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version number to block #65

Merged
merged 1 commit into from Nov 11, 2018
Merged

Conversation

hlongvu
Copy link

@hlongvu hlongvu commented Nov 11, 2018

My fix for #60. The block hash wil include this version number.
Please review.

@alexdovzhanyn
Copy link
Owner

Looks good! Seems like you also solved #64 here as well!

Copy link
Owner

@alexdovzhanyn alexdovzhanyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything here checks out. Pulled the code down, mined a few blocks, everything worked as expected. Great job here!

@alexdovzhanyn alexdovzhanyn merged commit 2b87c9d into alexdovzhanyn:master Nov 11, 2018
@alexdovzhanyn
Copy link
Owner

@chaintip @hlongvu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants