Add Dice game #2

alexyakunin · 2021-02-11T11:07:18Z

No description provided.

alexyakunin

Wrote some comments.

alexyakunin · 2021-02-11T11:09:22Z

src/Abstractions/BaseTypes.cs

+        public static DiceBoard Empty(int size) => EmptyCache.GetOrAdd(size, size1 => new DiceBoard(size1));
+
+        public int Size { get; }
+        public Dictionary<int, string[]> Cells { get; }


Most of Game* types are immutable, this dictionary is mutable.

alexyakunin · 2021-02-11T11:10:10Z

src/Abstractions/BaseTypes.cs

+            get {
+                var cellIndex = GetCellIndex(r, c);
+                if (cellIndex < 0 || cellIndex >= Cells.Count)
+                    return new string[] {"lightblue", "lightblue", "lightblue", "lightblue"};


IMO it's a bad idea to use string as underlying player color or something like this. Maybe an enum?

alexyakunin · 2021-02-11T11:10:40Z

src/Abstractions/BaseTypes.cs

+
+        public DiceBoard(int size)
+        {
+            var defaultValue = "lightblue";


Not sure what "lightblue" means :) Color? Empty cell?

alexyakunin · 2021-02-11T11:12:40Z

src/Host/HostSettings.cs

@@ -17,7 +17,7 @@ public class HostSettings

        // DBs
        public string UsePostgreSql { get; set; } =
-            "Server=localhost;Database=board_games_dev;Port=5432;User Id=postgres;Password=Fusion.0.to.1";
+            "Server=localhost;Database=board_games_dev;Port=5432;User Id=postgres;Password=pg051825";


IMO you shouldn't change the default password that matches the password from docker-compose.yml

Maybe just use the original docker-compose.yml?

alexyakunin · 2021-02-11T11:13:37Z

src/Host/Startup.cs

@@ -75,6 +75,8 @@ public void ConfigureServices(IServiceCollection services)
            HostSettings = tmpServices.GetRequiredService<HostSettings>();

            // DbContext & related services
+
+            // HostSettings.UseSqlite = true;


This commented out piece should be removed.

alexyakunin · 2021-02-11T11:14:39Z

src/UI/Dice/DiceRules.razor

+@attribute [MatchFor(typeof(DiceEngine), ComponentScopes.GameRules)]
+@inherits GameRulesBase
+
+<p><b>Rules</b>: Get to the finish line first.</p>


Ok, I'll write a bit more details here :)

alexyakunin · 2021-02-11T11:15:07Z

src/SharedServices/ClientServicesModule.cs

@@ -20,6 +20,7 @@ public override void Use()
        {
            // Game engines
            Services.TryAddEnumerable(ServiceDescriptor.Singleton<IGameEngine, GomokuEngine>());
+            Services.TryAddEnumerable(ServiceDescriptor.Singleton<IGameEngine, DiceEngine>());


FYI this changed in the latest game verison.

Check out the attributes on GomokuEngine & copy them to get this working.

alexyakunin · 2021-02-19T06:36:35Z

src/Abstractions/CharBoard.cs

+        public static DiceBoard Empty(int size) => EmptyCache.GetOrAdd(size, size1 => new DiceBoard(size1));
+
+        public int Size { get; }
+        public ImmutableDictionary<int, Cell> Cells { get; }


You don't need a dict if you use 100% index range from 0 to N :) You need an array :)

alexyakunin · 2021-02-19T06:37:49Z

src/Abstractions/CharBoard.cs

+
+        public enum Colors
+        {
+            Blue,


I would rather use CellStates vs Colors. Color is meaningless, but cell state - e.g. "BoostCell" - is meaninful.

alexyakunin · 2021-02-19T06:38:13Z

src/Abstractions/CharBoard.cs

+        public int Size { get; }
+        public ImmutableDictionary<int, Cell> Cells { get; }
+
+        public struct Cell


This thing definitely requires some serialization-related optimizations. Or maybe DiceBoard.

alexyakunin · 2021-02-19T06:39:22Z

src/Abstractions/CharBoard.cs

+        public struct Cell
+        {
+            public string Background;
+            public string[] Colors;


Why cell has multiple colors?

4 colors for all players (blue, green, red, yellow)

alexyakunin · 2021-02-19T06:39:31Z

src/Abstractions/CharBoard.cs

+        {
+            public string Background;
+            public string[] Colors;
+            public double[] Opacities;


Same for opacities?

Each cell has 1 background color and 4 "color + opacity" units.

alexyakunin · 2021-02-19T06:43:47Z

src/Abstractions/CharBoard.cs

+            Size = size;
+            var builder = ImmutableDictionary.CreateBuilder<int, Cell>();
+            for (int i = 0; i < size * size; i++) {
+                if (i == 10 || i == 27 || i == 44) {   // ForwardStep cells


I'd make this random.

Random can make infinite loop.

alexyakunin · 2021-02-19T06:44:32Z

src/Abstractions/Games/Dice.cs

+            var playerScore = oldPlayerScore += move.Value;
+            state.Steps[state.PlayerIndex] += 1;
+            var playerSteps = state.Steps[state.PlayerIndex];
+            if (playerScore == 10 || playerScore == 27 || playerScore == 44) {


This is kinda weird - i.e. I'd use board to check exactly this thing.

iqmulator added 8 commits February 9, 2021 15:36

dice

d00f575

Merge with updated Main branch

2331f5d

Fix migrations

603f7eb

Fix and merge conflicts

187f9ed

Merge branch 'main' into branch01

a06af13

dice game works for 2 players

b44cd41

dice game for 4 players is ready

a4bc099

max players = 4

3ba171d

alexyakunin commented Feb 11, 2021

View reviewed changes

iqmulator added 9 commits February 11, 2021 16:37

merge with updated main

0bf13c5

player paths in dice game

d98c600

merge with main

ed4ebc3

fix players path

2adf16b

add player color

b2979fa

add special cells

ba8bdcd

fix: remove garbage code

4119a59

up to 4 players, steps count, remove garbage

20f0f01

update Cells (insert structs)

67da876

alexyakunin commented Feb 19, 2021

View reviewed changes

iqmulator added 2 commits February 24, 2021 13:28

update dice game, make the board simpler

6e8a5a1

Merge branch 'main' into branch01

d84f276

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Dice game #2

Add Dice game #2

alexyakunin commented Feb 11, 2021

alexyakunin left a comment

alexyakunin Feb 11, 2021

alexyakunin Feb 11, 2021

alexyakunin Feb 11, 2021

alexyakunin Feb 11, 2021

alexyakunin Feb 11, 2021

alexyakunin Feb 11, 2021

alexyakunin Feb 11, 2021

alexyakunin Feb 11, 2021

alexyakunin Feb 11, 2021

alexyakunin Feb 19, 2021

alexyakunin Feb 19, 2021

alexyakunin Feb 19, 2021

alexyakunin Feb 19, 2021

iqmulator Feb 19, 2021

alexyakunin Feb 19, 2021

iqmulator Feb 19, 2021

alexyakunin Feb 19, 2021

iqmulator Feb 19, 2021

alexyakunin Feb 19, 2021

Add Dice game #2

Are you sure you want to change the base?

Add Dice game #2

Conversation

alexyakunin commented Feb 11, 2021

alexyakunin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment