Branch02 #5
Branch02 #5
Conversation
src/Abstractions/CharBoard.cs
Outdated
| @@ -61,6 +61,8 @@ protected virtual bool PrintMembers(StringBuilder builder) | |||
|
|
|||
| public int GetCellIndex(int r, int c) => r * Size + c; | |||
|
|
|||
| public int GetCardIndex(int r, int c) => r * 9 + c; | |||
src/Abstractions/GameEngine.cs
Outdated
| ? p with { Score = p.Score + score} | ||
| : p).ToImmutableList(), | ||
| }; | ||
| public abstract string Id { get; } |
src/Abstractions/Games/CardsPoint.cs
Outdated
| { } | ||
|
|
||
| [Service, ServiceAlias(typeof(IGameEngine), IsEnumerable = true)] | ||
| public class PointEngine : GameEngine<PointState, PointMove> |
There was a problem hiding this comment.
I'd rename this to PointGameEngine, PointGameState, and PointGameMove - PointXxx is a bit confusing.
src/Host/Program.cs
Outdated
| @@ -13,7 +13,7 @@ | |||
| // Looks like there is no better way to set _default_ URL | |||
| builder.Sources.Insert(0, new MemoryConfigurationSource() { | |||
| InitialData = new Dictionary<string, string>() { | |||
| {WebHostDefaults.ServerUrlsKey, "http://localhost:5030"}, | |||
| {WebHostDefaults.ServerUrlsKey, "http://localhost:5035"}, | |||
There was a problem hiding this comment.
This line should be reverted.
src/UI/Dice/DicePlay.razor
Outdated
| <tbody> | ||
| <tr> | ||
| @for (int i = 0; i < 2; i++) | ||
| { |
There was a problem hiding this comment.
Statement brackets should be on the same line.
| @@ -0,0 +1,185 @@ | |||
| @attribute [MatchFor(typeof(DiceEngine), ComponentScopes.GamePlay)] | |||
There was a problem hiding this comment.
General comment: nesting is pretty huge in this file. I'd probably extract some sub-components here.
src/UI/Dice/DicePlay.razor
Outdated
|
|
||
| private Task MoveAsync() | ||
| { | ||
| diceValue = GetRandomDigit(); |
There was a problem hiding this comment.
Hehe :) This stuff should normally happen on server, right? I mean, if your client can submit any digit it likes, pretty sure it won't be a fair game at all.
src/UI/Dice/DicePlay.razor
Outdated
| private Task MoveAsync() | ||
| { | ||
| diceValue = GetRandomDigit(); | ||
| var move = new DiceMove(MyPlayerIndex, diceValue); |
There was a problem hiding this comment.
Yep, diceValue shouldn't be a part of DiceMove - it should be generated on server side when you process the move there.
src/UI/Dice/DicePlay.razor
Outdated
| private Color GetDiceColor(int playerIndex) | ||
| => playerIndex == MyPlayerIndex ? Color.Success : Color.Danger; | ||
|
|
||
| private int GetRandomDigit() |
There was a problem hiding this comment.
So this should be a part of DiceEngine, I guess.
|
|
||
| } | ||
|
|
||
| <style> |
There was a problem hiding this comment.
Is it common to put style in the end of component?
| @@ -30,7 +30,7 @@ public abstract class GameEngine<TGameState, TGameMove> : IGameEngine | |||
|
|
|||
| public virtual Game Create(Game game) => game; | |||
| public abstract Game Start(Game game); | |||
| Game IGameEngine.Move(Game game, GameMove move) => Move(game, (TGameMove) move); | |||
| Game IGameEngine.Move(Game game, GameMove move) => Move(game, (TGameMove)move); | |||
| @@ -16,6 +20,7 @@ public ClientServicesModule(IServiceCollection services, IServiceProvider module | |||
|
|
|||
| public override void Use() | |||
| { | |||
|
|
|||
There was a problem hiding this comment.
Hmm, are you sure empty line is needed here?
| @attribute [MatchFor(typeof(TicEngine), ComponentScopes.GameRules)] | ||
| @inherits GameRulesBase | ||
|
|
||
| Just a Tic Tac Toe game... Ordindary. |
No description provided.