-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding tls and tls verify support for Kafka-logger #10104
base: master
Are you sure you want to change the base?
Conversation
@macdoor Will you also add the appropriate test cases? |
@Revolyssup ok |
properties = { | ||
verify = { | ||
type = "boolean", | ||
default = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need one more space
@macdoor the document of this plugin and the test case both needed. |
I still need sometime to learn how to write testcase.macdoor在 2023年9月15日,11:40,Sn0rt ***@***.***> 写道:
@macdoor the document of this plugin and the test case both needed.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@macdoor We are still waiting for you, thanks! |
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions. |
@macdoor are you going to work on this? |
ping @macdoor |
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions. |
Description
Adding tls and tls verify support for Kafka-logger, then it will support Kafka's SASL_SSL authentication mode
Fixes # (issue)
#9353
Checklist