Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename variable QUEUE_MAX_SIZE to QUEUE_INITIAL_SIZE #16040

Merged
merged 6 commits into from
May 24, 2024

Conversation

alei1206
Copy link
Contributor

@alei1206 alei1206 commented May 20, 2024

Purpose of the pull request

fix #16039 Modify the name of the variable, reduce the ambiguity

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to remove the initialize size, most workflow doesn't have 3000 tasks.

@SbloodyS SbloodyS added improvement make more easy to user or prompt friendly 3.2.2 labels May 21, 2024
@SbloodyS SbloodyS added this to the 3.2.2 milestone May 21, 2024
@alei1206
Copy link
Contributor Author

It's better to remove the initialize size, most workflow doesn't have 3000 tasks.

Sure,3000 is too big。Now I have removed the initial capacity

ruanwenjun
ruanwenjun previously approved these changes May 21, 2024
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @alei1206 please run 'mvn spotless:apply' to fix the code style

@alei1206
Copy link
Contributor Author

LGTM, @alei1206 please run 'mvn spotless:apply' to fix the code style

@rickchengx Thank you for reminding. Code has been submitted again

@alei1206 alei1206 requested a review from rickchengx May 22, 2024 11:41
@SbloodyS SbloodyS added 3.3.0 and removed 3.2.2 labels May 24, 2024
@SbloodyS SbloodyS modified the milestones: 3.2.2, 3.3.0 May 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.65%. Comparing base (f754611) to head (aeb4fd7).

Current head aeb4fd7 differs from pull request most recent head 6be6cf8

Please upload reports for the commit 6be6cf8 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #16040      +/-   ##
============================================
- Coverage     40.67%   40.65%   -0.02%     
+ Complexity     5226     5224       -2     
============================================
  Files          1380     1380              
  Lines         46011    46009       -2     
  Branches       4919     4919              
============================================
- Hits          18713    18706       -7     
- Misses        25373    25378       +5     
  Partials       1925     1925              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
14.2% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit 26f2aad into apache:dev May 24, 2024
62 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.3.0 backend improvement make more easy to user or prompt friendly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement][Master] The variables in the code are incorrect and there are ambiguity
5 participants