-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename variable QUEUE_MAX_SIZE to QUEUE_INITIAL_SIZE #16040
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to remove the initialize size, most workflow doesn't have 3000 tasks.
Sure,3000 is too big。Now I have removed the initial capacity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @alei1206 please run 'mvn spotless:apply' to fix the code style
@rickchengx Thank you for reminding. Code has been submitted again |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #16040 +/- ##
============================================
- Coverage 40.67% 40.65% -0.02%
+ Complexity 5226 5224 -2
============================================
Files 1380 1380
Lines 46011 46009 -2
Branches 4919 4919
============================================
- Hits 18713 18706 -7
- Misses 25373 25378 +5
Partials 1925 1925 ☔ View full report in Codecov by Sentry. |
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose of the pull request
fix #16039 Modify the name of the variable, reduce the ambiguity
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md