[FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction #24805
+75
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmitSinkFunction As part of FLIP-453, these interfaces are annotated with `@Deprecated` and point to their successors. * org.apache.flink.streaming.api.functions.sink#SinkFunction * org.apache.flink.streaming.api.functions.sink#SocketClientSink * org.apache.flink.streaming.api.functions.sink#TwoPhaseCommitSinkFunction
As part of FLIP-453, the following interfaces are annotated with `@Public` * org.apache.flink.api.connector.sink2#Committer * org.apache.flink.api.connector.sink2#CommitterInitContext * org.apache.flink.api.connector.sink2#CommittingSinkWriter * org.apache.flink.api.connector.sink2#Sink * org.apache.flink.api.connector.sink2#SinkWriter * org.apache.flink.api.connector.sink2#StatefulSinkWriter * org.apache.flink.api.connector.sink2#SupportsCommitter * org.apache.flink.api.connector.sink2#SupportsWriterState * org.apache.flink.api.connector.sink2#WriterInitContext
This commit replaces all usage of the old DiscardingSink (that was based on the SinkFunction), with the new V2 DiscardingSink (that is based on the SinkV2 APIs) It also deprecates the old DiscardingSink by annotating it as `@Deprecated`
This commit replaces all usage of the old PrintSinkFunction (that was based on the SinkFunction), with the new PrintSink (that is based on the SinkV2 APIs) It also deprecates the PrintSinkFunction by annotating it as `@Deprecated`
The PrintSink has been there since Flink 1.16.0 and should have been promoted earlier already.
MartijnVisser
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Promote Unified Sink API V2 to Public and Deprecate SinkFunction
Brief change log
da30c2f Deprecate SinkFunction, SocketClientSink and TwoPhaseCommitSinkFunction
aa94e38 Promote SinkV2 interfaces
b9c692d Use new V2 DiscardingSink
2a11eeb Use new PrintSink
50b7df7 Promote PrintSink from
@PublicEvolvingto@PublicVerifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): yesDocumentation