Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] upgrade webapp angular deps version #1707 #1987

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

Aias00
Copy link
Contributor

@Aias00 Aias00 commented May 14, 2024

What's changed?

link #1707

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

Signed-off-by: aias00 <rokkki@163.com>
@tomsun28
Copy link
Contributor

hi thanks👍 lgtm, this involves a major front-end version upgrade, but we are releasing a new version.
Please wait it will take some days to merge.

@tomsun28 tomsun28 added the good first pull request Good for newcomers label May 14, 2024
@tomsun28 tomsun28 self-requested a review May 14, 2024 08:43
@Aias00
Copy link
Contributor Author

Aias00 commented May 14, 2024 via email

@tomsun28 tomsun28 added this to the 1.6.1 milestone May 24, 2024
Copy link

@yykaue yykaue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upgrade webapp angualr delon ngzorro alain version to 17 latest

tomsun28
tomsun28 previously approved these changes Jun 12, 2024
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!thanks.

@tomsun28
Copy link
Contributor

hi, i try to login the console, the error happen. It seems the this.reuseTabService is null.

login.component.ts:138 ERROR TypeError: Cannot read properties of null (reading 'clear')
    at Object.next (login.component.ts:145:30)
    at ConsumerObserver.next (Subscriber.js:91:33)
    at SafeSubscriber._next (Subscriber.js:60:26)
    at SafeSubscriber.next (Subscriber.js:31:18)
    at subscribe.innerSubscriber (switchMap.js:14:144)
    at OperatorSubscriber._next (OperatorSubscriber.js:13:21)
    at OperatorSubscriber.next (Subscriber.js:31:18)
    at map.js:7:24
    at OperatorSubscriber._next (OperatorSubscriber.js:13:21)
    at OperatorSubscriber.next (Subscriber.js:31:18)

Comment on lines 43 to 58
"@angular/animations": "^17.3.10",
"@angular/common": "^17.3.10",
"@angular/compiler": "^17.3.10",
"@angular/core": "^17.3.10",
"@angular/forms": "^17.3.10",
"@angular/platform-browser": "^17.3.10",
"@angular/platform-browser-dynamic": "^17.3.10",
"@angular/router": "^17.3.10",
"@delon/abc": "^17.3.1",
"@delon/acl": "^17.3.1",
"@delon/auth": "^17.3.1",
"@delon/cache": "^17.3.1",
"@delon/form": "^17.3.1",
"@delon/mock": "^17.3.1",
"@delon/theme": "^17.3.1",
"@delon/util": "^17.3.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here can we lock the version like before? "@angular/common": "^17.3.10"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u mean this change cause the error ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here can we lock the version like before? "@angular/common": "^17.3.10"

okay, we will lock the version like before ~

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u mean this change cause the error ?

No, just want to lock the version to avoid potential problems. same with yarn.lock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants