-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] upgrade webapp angular deps version #1707 #1987
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: aias00 <rokkki@163.com>
hi thanks👍 lgtm, this involves a major front-end version upgrade, but we are releasing a new version. |
this is still working on
…---- Replied Message ----
| From | ***@***.***> |
| Date | 05/14/2024 16:44 |
| To | apache/hertzbeat ***@***.***> |
| Cc | aias00 ***@***.***>,
Author ***@***.***> |
| Subject | Re: [apache/hertzbeat] [feature] upgrade webapp angular deps version #1707 (PR #1987) |
hi thanks👍 lgtm, this involves a major front-end version upgrade, but we are releasing a new version.
Please wait it will take some days to merge.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Signed-off-by: aias00 <rokkki@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
upgrade webapp angualr delon ngzorro alain version to 17 latest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!thanks.
hi, i try to login the console, the error happen. It seems the
|
web-app/package.json
Outdated
"@angular/animations": "^17.3.10", | ||
"@angular/common": "^17.3.10", | ||
"@angular/compiler": "^17.3.10", | ||
"@angular/core": "^17.3.10", | ||
"@angular/forms": "^17.3.10", | ||
"@angular/platform-browser": "^17.3.10", | ||
"@angular/platform-browser-dynamic": "^17.3.10", | ||
"@angular/router": "^17.3.10", | ||
"@delon/abc": "^17.3.1", | ||
"@delon/acl": "^17.3.1", | ||
"@delon/auth": "^17.3.1", | ||
"@delon/cache": "^17.3.1", | ||
"@delon/form": "^17.3.1", | ||
"@delon/mock": "^17.3.1", | ||
"@delon/theme": "^17.3.1", | ||
"@delon/util": "^17.3.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here can we lock the version like before? "@angular/common": "^17.3.10"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
u mean this change cause the error ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here can we lock the version like before?
"@angular/common": "^17.3.10"
okay, we will lock the version like before ~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
u mean this change cause the error ?
No, just want to lock the version to avoid potential problems. same with yarn.lock
What's changed?
link #1707
Checklist
Add or update API