-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
THRIFT-5773: Strong UUID for C++ #2958
base: master
Are you sure you want to change the base?
THRIFT-5773: Strong UUID for C++ #2958
Conversation
803bc86
to
45e11bb
Compare
45e11bb
to
5e16321
Compare
5e4bacc
to
81de8e6
Compare
- Not yet sure where the issue might be
- Define the functions - Cross test of UUID not implemented
- The public data member is probably not convention, but this should be a light wrapper for added utility. - Stick with uint8_t[16] as discussed on ticket - Cleanup and unit tests added
- And fix begin() and end() - More unit test
- Test for network order
81de8e6
to
0f879b9
Compare
- Adds trivial migration for projects already using boost - This is header only thus no need to compile the lib any different
- The reason why the range library of C++20 exits
- To mirror the cmake side
NB: This PR also includes #2968 (THRIFT-5776) since I had to fix those errors before I could make progress on the makefile related unit tests. I have rebased on that branch |
I see there are MSVC build errors related to this, I will have to look into this |
- To avoid issue with MSVC and crypto headers needed - Mix up the UUIDs a bit to ensure the tests are unrelated to the uuid - Generated random uuids using an external tool
@Jens-G I see there are some python tests failing in the MSVC build, would my changes be the cause (I can't think that it would be but I have been wrong in the past) |
- It felt out of place - Review feedback
- Review feedback and generally a good idea
THRIFT-5773: UUID wrapper for C++
Adds a strong UUID wrapper for C++.
The use of a
std::string
can be misleading and since C++ is a strong typed language, this makes the most sense.[skip ci]
anywhere in the commit message to free up build resources.