Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP checks: add an option to prevent Cabot from following redirections #671

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

thomasleveil
Copy link
Contributor

fix #20

image

image

Thomas LEVEIL added 3 commits June 11, 2019 18:45
…redirects

fix arachnys#20

- The setting is per-check
- default is 'checked' which means Cabot does follow redirects (as before this change)

- [x] db migration
- [x] views
- [x] REST api
@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@56cfed4). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #671   +/-   ##
=========================================
  Coverage          ?   80.92%           
=========================================
  Files             ?       46           
  Lines             ?     2956           
  Branches          ?      179           
=========================================
  Hits              ?     2392           
  Misses            ?      505           
  Partials          ?       59
Impacted Files Coverage Δ
cabot/settings.py 68.42% <ø> (ø)
cabot/rest_urls.py 90.9% <ø> (ø)
cabot/cabotapp/views.py 70.89% <ø> (ø)
cabot/cabotapp/tasks.py 61.66% <100%> (ø)
cabot/cabotapp/models/base.py 79.55% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56cfed4...38c7406. Read the comment docs.

@jakubgs
Copy link

jakubgs commented Oct 21, 2020

This looks pretty useful, but I guess it's abandoned by now?

@thomasleveil
Copy link
Contributor Author

thomasleveil commented Oct 21, 2020

I guess so, no new release in years. And Python 2 isn't supported anymore.

Here you can find popular forks which might be maintained

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Following redirects on HTTP Checks
2 participants