fix: ensure node phases propagate correctly. Fixes #12869 #12991
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12869
The previous code contained a logic error and always inherited node.Phase, this isn't always desirable, on failure it should inherit the parents phase.
In addition to this, the codebase also updates the outbound nodes for the targetTasks. This fix was contributed by @Joibel even though the commits here do not indicate this.
This fix is an interim fix while I rewrite some of the DAG code, generally speaking the DAG part of the codebase has a more dense population of bugs, enough to the point that I think it warrants a rewrite.
Verification
Tested
and it is marked as
Error
as expected.