Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CLI related merged PRs to the documentation #423

Merged
merged 3 commits into from
May 30, 2024

Conversation

didierjoomun
Copy link
Contributor

@didierjoomun didierjoomun commented May 16, 2024

DEPRECATED message updated with warning sign and DEPRECATED text adde to the page title.

@igorpecovnik
Copy link
Member

Lets merge this once there are a few of new instructions ready. So people see its not only this "deprecated" sign ;)

@didierjoomun didierjoomun changed the title Modified warning message and added "DEPRECATED" in the title of the page. Added CLI related merged PRs to the documentation May 18, 2024
@igorpecovnik
Copy link
Member

Thank you, this looks like a good start!

@EvilOlaf @rpardini @lanefu @ColorfulRhino ...

Any suggestions?
Can we now start to block new features merge when they come without such entry?

@EvilOlaf
Copy link
Member

I suggest to change wording from options to commands since this is what those are.

@lanefu
Copy link
Member

lanefu commented May 18, 2024

I suggest to change wording from options to commands since this is what those are.

Maybe leave the heading there to say build options have been replaced with build commands and have build command section immediately below.

Copy link
Member

@igorpecovnik igorpecovnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge this part.

@igorpecovnik igorpecovnik merged commit 4cf2ff4 into armbian:master May 30, 2024
@ColorfulRhino
Copy link

Can we now start to block new features merge when they come without such entry?

Since documentation is important, especially for things like commands, I vote yes 👍 (albeit a bit late)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants