Unify tracking of metrics and events in CloudHandler #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Disregard coveralls, it's confused because of the refactoring. |
|
I'm sorry, but I'm no longer interested in this project. Also, a lot of other interesting work :) |
|
No worries mate, appreciate all the work you put in to it! |
MovieStoreGuy
previously approved these changes
May 18, 2021
tiedotguy
force-pushed
the
tdg/unify-cloudhandler-tracking
branch
from
cef43dd
to
6115481
Compare
tiedotguy
force-pushed
the
tdg/unify-cloudhandler-tracking
branch
from
6115481
to
89112f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having a per source for metrics queue and a per source for events queue, this unifies it in to a single per host for anything queue.
This simplifies the logic, and removes what appears to be a logic bug: #341 (comment)