This repository has been archived by the owner on Jul 23, 2019. It is now read-only.
Add multi cursor click selections #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstoiko
approved these changes
Jul 18, 2018
|
Apologies for the mistakenly submitted (and unsolicited) review. I have no way to undo it 馃憥. |
40 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #107
You can hold alt and click on multiple points to multiple cursors. Also, when using a selection modifier on top of adding a new cursor (like click+drag or double/triple click), I fixed it so the modifier only applied on the latest/current selection (earlier it would affect all selections which had some funny effects 馃槢)
However, to enable selection modifiers only affecting the last cursor, I'm simply pushing a new cursor to
selections(instead of binary searching to insert it in the right order). This lets me simply refer tolast_mut(). I don't understand what the point of sorting it correctly is (would love an explanation, cc @nathansobo) but if we need to retain that, I can update this PR to have a variable tracking the newest "cursor".