Electron 6 Take Two #21079

lkashef · 2020-07-16T08:08:33Z

Original Issue: #20764

TODO

Update the CI with the proper node and npm versions
Update electron version
Update electron dependencies (electron-chromedriver and electron-mksnapshot) to match the electron version
Get the app to bootstrap on the new electron version
Once the build job passes make sure the artifacts are runnable/installable
Fix any failing tests and make sure the test jobs are passing on the CI
Test the artifacts against the regression checklist below
Check performance issue after upgrade on Linux (Check Slow UI and busy GPU thread with Electron 6 on Linux (with Intel CPU and no GPU?) #20924 and the conversation below)

BLOCKERS AND ISSUES

Regression Checklist

General testing

Check for regressions experienced in previous upgrades

Text Input/Keybindings

See how to setup keyboard layouts.

IME not working (1.19.0-beta2: Cursor stucks at the first letter when using macOS Chinese IME #14911)
- macOS
- Windows 10
- Ubuntu
Repro steps
1. Install an IME layout, for example Pinyin simplified
2. Open Atom and use the layout you installed as the keyboard layout
3. Example, if you picked Pinyin simplified type in zhongwenshuru
Expected: in Pinyin simplified 中文输入 is expected

Issues we've seen: Only shows latin first character and not every character typed.
macOS: Key binding with composition characters are ignored (key-mappings with alt don't suppress Mac OS composition characters anymore (atom-1.19) #15189)
Repro steps
1. Open your keymap.cson file and add the following:
```
'atom-text-editor':
  # use hjkl; vim-like when pressing alt (word by word, paragraph by paragraph)
  # or alt (letter by letter)
  'alt-h': 'core:move-left'
  'alt-j': 'core:move-down'
  'alt-k': 'core:move-up'
  'alt-l': 'core:move-right'
```
2. Save keymap.cson and reload atom.
3. Try the new keymappings under ABC - Extended keyboard layout
Expected: the keybindings work

Issues we've seen: it types out the modified keys and ignores the key mapping
macOS: Composition characters mess up insertion point (Composition characters mess up insertion point #15344)
Repro steps
1. Open keymap.cson and add the following:
```
'atom-text-editor':
  'alt-n': 'core:move-down'
  'alt-o': 'core:move-down'
```
2. Have the following in your buffer:
```
Foo
Bar
```
3. Have the cursor at the beginning of file(before F character) Type alt-n, then arrow right, then insert a character. Observe that the character is inserted at the beginning of the line (where the alt-n left you).
4. Repeat steps using alt-o instead of alt-n.
Expected: Both alt-o and alt-n behave the same

Issues we've seen:
Ubuntu: Keystrokes involving ctrl resolve to the default layout instead of the active layout (Keystrokes involving ctrl on Linux resolve to the default layout instead of the active layout #13170)
Repro steps

This should be tested on Linux with gnome
1. Install a Linux ditro with gnome, for example Ubuntu
2. Install French AZERTY and English US QWERTY layouts
3. Change the default layout to be French AZERTY
4. Open Atom and switch to English US QWERTY layout
5. Press ctrl-w
Expected: core:close to dispatch (Or the keybinding-resolver to resolve to ctrl-w). Should be resolving to the keyboard layout that is chosen and not the OS default layout.

Issues we've seen: core:undo dispatched because it was resolved as ctrl-z because AZERTY has Z where W is on QWERTY.
Other keyboard layouts on new Electron version
- macOS: ABC - Extended
- macOS: Slovak
- macOS: U.S. International
- macOS: Squirrel (https://github.com/rime/squirrel)
- macOS: Full-Width Alphanumeric (Google) - Japanese layout (https://www.google.co.jp/ime/)
- Windows: U.S.
- Linux: Pinyin Simplified

UI

Other

Supported Versions of OS (Atom 1.19.0 crashes instantly after launching #15297)
- macOS
- Windows 10
- Ubuntu
Repro steps
1. Check the list of supported platforms Electron Master
2. Check what version is listed as minimum for each platform on https://atom.io and https://atom.io/faq
Expected: https://atom.io and https://atom.io/faq to display the same versions as the Electron documentation

Issues we've seen: macOS version support changed and https://atom.io and https://atom.io/faq was not updated
macOS : Native tabs (Native tabs on macOS #14711)
Repro steps
1. Open two atom windows on mac
2. Go to View in menus and check Show Tab Bar
3. Do this for both Atom windows.
4. Drag one atom window to the other via tab bar
Expected:
Native Tab bar shows up and able to drag different windows to each other. Also make sure UI isn't messed up.

Issues we've seen:
Native Tab Bar doesn't work and messes up UI when enabled
Ubuntu with KDE: Menu uses 100% CPU (Globalmenu consumes 100% CPU and does not work electron/electron#8455, Menus not working in plasma 5.9 with global menu enabled #13885)
Repro steps
1. Install Atom on Ubuntu KDE. [instructions]
2. Enable KDE plasma global menu: Right-click on the desktop -> Add Panel => Application Menu Bar. [demo]
3. Start Atom.
4. Try to use the desktop menu.
Expected:
Desktop menu items work

Issues we've seen:
Desktop menu items do nothing when you click on things.
macOS: Slovak QWERTZ (Slovak QWERTZ does not resolve keys correctly on macOS atom-keymap#223)
Repro steps
1. Install Slovak keyboard layout on mac
2. Open keyboard viewer to see the keys are are suppose to show up and open keyboard resolver on atom.
3. hit cmd+'.
Expected: Resolves to cmd+' like it shows on keyboard viewer on mac.

Issues we've seen: It resolves to ctrl+§
macOS: IME jump (1.20.0: Popup jump when using macOS Chinese IME #15696)
Repro steps
1. Install an IME layout, for example Chinese pinyin
2. Type one character
Expected:
Expected the IME to be positioned at under the character you entered
Issues we've seen: The IME window is in the top left corner. When you enter the second character it jumps to be positioned under the text

⬆️ find-and-replace@0.219.5

aminya · 2020-07-22T08:59:28Z

Thank you for the recent updates. Both find and replace and scrolling in the settings view issues are gone.

I tested this with the artifacts from @DeeDeeG. This hidden issue does not happen on those. Maybe something is wrong with my working branch.

However, now I cannot search for packages for downloading in the settings view. Does this happen for others or it is just me? I built this on a branch that had other changes, so I am not certain if it is caused by those two updates.

⬆️ settings-view@0.261.5

darangi · 2020-07-22T09:10:02Z

Thank you for the recent updates. Both find and replace and scrolling in the settings view issues are gone.

I tested this with the artifacts from @DeeDeeG. This hidden issue does not happen on those. Maybe something is wrong with my working branch.

Yea, I also confirmed it works fine on this build. Thanks for the effort.

aminya

Thank you so much for this work.

aminya · 2020-07-28T10:02:23Z

Let us know if there is anything blocking this from merging. We may be able to help.

script/vsts/platforms/linux.yml

aminya · 2020-08-10T05:02:00Z

Could you check my comment at atom/apm#889 (comment)

I am seeing some issues with apm. The Node version difference makes the native modules that are compiled using apm unusable. We should make the Node versions identical on apm and atom.

I reproduced the error with the binaries uploaded in the CI of this PR. You can reproduce the error by installing https://atom.io/packages/ink

jeff-hykin · 2020-08-11T12:34:17Z

On a similar note @aminya , could the version of node being used be added to the package.json dependencies? (E.g. npm install -s node)

The atom build fails with newer versions of node because of native modules, but the version of node isn't mentioned in the documentation or repo AFAIK

aminya · 2020-08-12T04:42:18Z

On a similar note @aminya , could the version of node being used be added to the package.json dependencies? (E.g. npm install -s node)

The atom build fails with newer versions of node because of native modules, but the version of node isn't mentioned in the documentation or repo AFAIK

Yes, we should unify the Node versions and write it down in the package.json.

If for some reason, the old Electron was not picky about the Node versions, the new one is, and we should absolutely make this unification before merging this pull request.

aminya · 2020-08-19T18:48:42Z

@darangi apm 2.5.1 solves the issue for Electron 5. You should merge this as well: atom/apm#896

the-j0k3r · 2020-08-20T10:08:06Z

Congrats on the merge =) and thanks for the work on these electron bumps

the-j0k3r · 2020-08-25T14:13:13Z

Please dont forget #20819 is fixed with electron 6.x merged

We have been experiencing linux build failures on our CI. This failure seem to be cause by #21079. Related conversation atom/apm#900

lkashef and others added 30 commits May 19, 2020 07:19

⬆️ electron@6.1.12

1d263e2

electron-chromedriver@6.0.0

c8ad0e7

electron-mksnapshot@6.0.0

a16d2d1

scrollbar-style@3.2.1

e4a1a8e

watcher@1.3.3

b516f60

Upgrade scrollbar-style without electron

b0669ec

electron 6 again and bump node to 12.4.0

9e01d5a

Update npm version

ed8f4f9

try removing npm upgrade in mac job

0c25fde

install npm

237d3ee

Update macos.yml

5562f5f

debug npm upgrade fail

ad3c1fa

update npm path

1c5bf90

bump atom/watcher@1.3.3

8914766

remove log and verify lint

98bb0d4

disable cache save

ffb34f3

bump watcher to 1.3.4-0

00151d4

correct @atom/watcher in package lock

1bf5f60

Update package-lock.json

40cb843

Update electron dependencies

29f184d

Fix node versioin

397afde

downgrade to electron 13 to get targets.hostArch

c3f824a

Update script to support electron-packager 14

891c80a

check out build on electron 7

7389cff

Upgrade npm

9dcac63

back to electron 6

a8047f8

Update package-lock.json

985dc66

Merge branch 'master' into electron-6.1.12

39d2bd4

Fix uploadToServer can't be null

29a9d32

Update webdriverio config to match the new schema

ece51f9

darangi mentioned this pull request Jul 21, 2020

⬆️ settings-view@0.261.5 #21096

Merged

Merge pull request #21095 from atom/find-and-replace-0.219.5

be98331

⬆️ find-and-replace@0.219.5

Merge pull request #21096 from atom/settings-view-0.261.5

bc4309b

⬆️ settings-view@0.261.5

aminya approved these changes Jul 23, 2020

View reviewed changes

aminya mentioned this pull request Jul 24, 2020

Bump electron link to 0.4.3 #21026

Closed

DeeDeeG mentioned this pull request Jul 28, 2020

Slow UI and busy GPU thread with Electron 6 on Linux (with Intel CPU and no GPU?) #20924

Open

1 task

DeeDeeG reviewed Jul 31, 2020

View reviewed changes

script/vsts/platforms/linux.yml Show resolved Hide resolved

This was referenced Jul 31, 2020

⬆️ electron@6.1.12 atom-community/atom#72

Merged

⬆️ electron@6.1.12 atom-community/atom#73

Merged

⬆️apm@2.5.1

ed3bea9

⬆️ apm@2.5.2

f208f2f

darangi merged commit 50a74a5 into master Aug 20, 2020

This was referenced Aug 25, 2020

sudo is not working in x-terminal anymore bus-stop/x-terminal#148

Closed

no sudo in terminals created with child_process.spawn #20819

Open

sadick254 mentioned this pull request Sep 7, 2020

update npm atom/apm#900

Closed

sadick254 added a commit that referenced this pull request Sep 9, 2020

Update node to 12.16.3

635f721

We have been experiencing linux build failures on our CI. This failure seem to be cause by #21079. Related conversation atom/apm#900

sadick254 mentioned this pull request Sep 9, 2020

Update node to 12.16.3 #21284

Merged

sadick254 added a commit that referenced this pull request Sep 9, 2020

Update node to 12.16.3

037b4b6

We have been experiencing linux build failures on our CI. This failure seem to be cause by #21079. Related conversation atom/apm#900

sadick254 added a commit that referenced this pull request Sep 9, 2020

Update node to 12.16.3

23f9fca

We have been experiencing linux build failures on our CI. This failure seem to be cause by #21079. Related conversation atom/apm#900

DeeDeeG mentioned this pull request Oct 8, 2020

Consider mentioning Electron 6 in the release notes for Atom 52.0 #21454

Closed

sadick254 deleted the electron-6.1.12-bump-electron-packager-from-git branch October 25, 2021 19:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Electron 6 Take Two #21079

Electron 6 Take Two #21079

lkashef commented Jul 16, 2020 •

edited by darangi

aminya commented Jul 22, 2020 •

edited

darangi commented Jul 22, 2020

aminya left a comment •

edited

aminya commented Jul 28, 2020

aminya commented Aug 10, 2020 •

edited

jeff-hykin commented Aug 11, 2020

aminya commented Aug 12, 2020 •

edited

aminya commented Aug 19, 2020

the-j0k3r commented Aug 20, 2020

the-j0k3r commented Aug 25, 2020

Electron 6 Take Two #21079

Electron 6 Take Two #21079

Conversation

lkashef commented Jul 16, 2020 • edited by darangi

TODO

BLOCKERS AND ISSUES

Regression Checklist

General testing

Check for regressions experienced in previous upgrades

Text Input/Keybindings

UI

Other

aminya commented Jul 22, 2020 • edited

darangi commented Jul 22, 2020

aminya left a comment • edited

Choose a reason for hiding this comment

aminya commented Jul 28, 2020

aminya commented Aug 10, 2020 • edited

jeff-hykin commented Aug 11, 2020

aminya commented Aug 12, 2020 • edited

aminya commented Aug 19, 2020

the-j0k3r commented Aug 20, 2020

the-j0k3r commented Aug 25, 2020

lkashef commented Jul 16, 2020 •

edited by darangi

aminya commented Jul 22, 2020 •

edited

aminya left a comment •

edited

aminya commented Aug 10, 2020 •

edited

aminya commented Aug 12, 2020 •

edited