This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Update atom.sh #25741
Open
Update atom.sh #25741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes 'DESKTOP_SESSION' is not defined, e.g. using xrdp with Ubuntu mate: printenv | grep DESK MATE_DESKTOP_SESSION_ID=this-is-deprecated XDG_SESSION_DESKTOP=mate XDG_CURRENT_DESKTOP=MATE The result is the message starting atom: "expr: syntax error: missing argument after ‘8’ " Simply putting quotes fixes it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug
#25740
Description of the Change
by quoting the result of $(...) it is taken as empty string so that substring command gets the right amount of parameter
Alternate Designs
non
Possible Drawbacks
non
Verification Process
Using shellcheck confirms the change. Starting atom after the change works flawless with and without 'DESKTOP_SESSION' defined.
Release Notes
Fix error message in case DESKTOP_SESSION is not defined