Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Use addEventListener #2723

Closed
wants to merge 1 commit into from
Closed

Conversation

icecream17
Copy link
Contributor

Attempt 2 (See attempt 1: #2722)

I have no idea why this error exists, but at least this is a change since I use removeEventListener too.

Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.

Description of the Change

Screenshot or Gif

Applicable Issues

(theoretical)

fixes #769
fixes #954
resolves #2722

I have no idea why this error exists, but at least this is a change since I use `removeEventListener` too.
@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #2723 (4911998) into master (2053290) will decrease coverage by 0.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2723      +/-   ##
==========================================
- Coverage   93.46%   92.93%   -0.53%     
==========================================
  Files         237      237              
  Lines       13213    13213              
  Branches     1900     1900              
==========================================
- Hits        12349    12279      -70     
- Misses        864      934      +70     
Impacted Files Coverage Δ
lib/worker-manager.js 62.34% <0.00%> (-28.46%) ⬇️
lib/git-shell-out-strategy.js 99.05% <0.00%> (-0.76%) ⬇️
lib/controllers/root-controller.js 84.02% <0.00%> (+0.24%) ⬆️
lib/controllers/commit-controller.js 93.75% <0.00%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2053290...4911998. Read the comment docs.

@icecream17 icecream17 closed this Oct 25, 2021
@icecream17 icecream17 deleted the dont-attempt-call branch October 25, 2021 18:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant