This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
[chore] Use marked v4 #2731
Open
[chore] Use marked v4 #2731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied from #2 Actually updating to v4.0.10 The only relevant breaking change: https://github.com/markedjs/marked/releases/tag/v4.0.0 is that the default export is removed: `({marked} = require('marked'))` Parens are required to make it not a SyntaxError. Only other change is that the docs: https://marked.js.org/using_advanced recommend using sanitize on the output instead of in the options
Codecov Report
@@ Coverage Diff @@
## dependabot/npm_and_yarn/marked-4.0.10 #2731 +/- ##
=========================================================================
+ Coverage 93.43% 93.47% +0.04%
=========================================================================
Files 237 237
Lines 13213 13212 -1
Branches 1900 1900
=========================================================================
+ Hits 12345 12350 +5
+ Misses 868 862 -6
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Requirements
Description of the Change
Copied from icecream17#2
Actually updating to v4.0.10
The only relevant breaking change: https://github.com/markedjs/marked/releases/tag/v4.0.0
is that the default export is removed:
({marked} = require('marked'))Parens are required to make it not a SyntaxError.
Only other change is that the docs: https://marked.js.org/using_advanced
recommend using sanitize on the output instead of in the options
The tests should pass (except for the ones that failed in #2724): icecream17#2
Although I don't know why there's more coverage
Screenshot or Gif
Applicable Issues