Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Explicitly set contextIsolation to false #2789

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Explicitly set contextIsolation to false #2789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9151038
Compatible with Electron 12
Oct 6, 2022
5d0a5b5
Fix ERESOLVE could not resolve with eslint
Oct 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 11 additions & 2 deletions lib/worker-manager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,8 +267,17 @@ export class RendererProcess {
this.onStdinError = onStdinError;
this.onExecStarted = onExecStarted;

this.win = new BrowserWindow({show: !!process.env.ATOM_GITHUB_SHOW_RENDERER_WINDOW,
webPreferences: {nodeIntegration: true, enableRemoteModule: true}});
this.win = new BrowserWindow({
show: !!process.env.ATOM_GITHUB_SHOW_RENDERER_WINDOW,
webPreferences: {
nodeIntegration: true,
enableRemoteModule: true,

// The default of contextIsolation is changed to true so we'll have to set it to false.
// See https://github.com/electron/electron/issues/23506 for more information
contextIsolation: false
},
});
this.webContents = this.win.webContents;
// this.webContents.openDevTools();

Expand Down