This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Generate Grammar using PHP Manual as input #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks pretty good to me, what's the next step here on this? Anyone from the Atom team able to review this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and use atom-syntax-tools, to make grammar easier to maintain.
Intention for this was a fix for indented phpdoc comments, which were not highlighted correctly. Fixing the grammar was almost impossible, because it is huge and has lines of several thousand characters long. So I started to move the grammar beeing generated using atom-syntax-tools and using the PHP Documentation as input.
There is still a lot to be done, but this state fixes the initial indented phpdoc bug and the grammar
is a lot easier to maintain. Before I continue with removing unneccessary noise from php-grammar.coffee,
I want to see, if you will accept such big changes.
Best regards, Kiwi