Ensure secret exists when tyring to read as text

atom · Nov 7, 2022 · 5dc6af0 · 5dc6af0
1 parent deae59a
commit 5dc6af0
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/src/keytar_posix.cc b/src/keytar_posix.cc
@@ -161,7 +161,16 @@ KEYTAR_OP_RESULT FindCredentials(const std::string& service,
       reinterpret_cast<char*>(g_hash_table_lookup(itemAttrs, "account")));
 
     SecretValue* secret = secret_item_get_secret(item);
-    char* password = strdup(secret_value_get_text(secret));
+    if (secret == NULL) {
+      // keystore is not open, secret is NULL which may lead to a crash in secret_value_get_text
+      continue;
+    }
+
+    const gchar* secret_text = secret_value_get_text(secret);
+    char* password = NULL;
+    if (secret_text != NULL) {
+      password = strdup(secret_text);
+    }
 
     if (account == NULL || password == NULL) {
       if (account)