This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Added support for armv7l arch (Raspberry Pi 32bit) #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sergiou87 would you mind taking a look at this when you have a minute please? |
|
Yes, sorry! It's all looking good, let's see if CI gives us all 🟢 |
|
@nzapponi seems like it's not finding |
|
Whoops, sorry, my bad. Let me fix that |
|
This should do it @sergiou87 |
sergiou87
approved these changes
Feb 11, 2022
|
@sergiou87 do you have any plans to release a new version including this PR anytime soon? Thanks! |
|
No plans, but I will do one soon (hopefully this week). We're kind of busy with GitHub Desktop releases at the moment, sorry, but I will let you know 😄 |
Merged
|
@nzapponi 7.9.0 should be ready and include armv7l binaries 😄 Please let me know if that works |
|
That's awesome, thank you!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for Adding, Changing, or Removing a Feature
Issue or RFC Endorsed by Atom's Maintainers
#401
Description of the Change
Added support for prebuilt binaries for 32 bit ARM architecture. This is useful when compiling Electron apps that are supposed to also work on Raspberry Pi (most userlands are 32 bit there).
Alternate Designs
Not having a prebuilt binary means that every app needs to be compiled on a separate machine, which is painful.
Possible Drawbacks
None that I can think of
Verification Process
Release Notes