Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

package: adopt prettier-standard style #310

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

package: adopt prettier-standard style #310

wants to merge 3 commits into from

Commits on Sep 26, 2020

  1. package: install prettier-standard and define linting scripts 

    This'll help to catch any errors in new code and keep its style consistent
While we're at it also uninstall unused `coffeelint` and remove files belonging to it
    @fluvf
    fluvf committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    100c1ad View commit details
    Browse the repository at this point in the history

  2. package: update deps and reorder package.json 

    Also moves `temp` to `devDependencies`, as it's only used by specs

The reorder isn't necessary, but I feel it is cleaner
    @fluvf
    fluvf committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    e8024c8 View commit details
    Browse the repository at this point in the history

  3. package: run prettier-standard --lint and fix errors 

    Almost all of these changes were made automatically

List of errors that had to be resolved manually:

(`no-template-curly-in-string` errors were resolved by turning the rule off)
.../snippets/lib/snippets.js
  156:31  error  Expected error to be handled                      handle-callback-err
  164:9   error  Unexpected literal in error position of callback  standard/no-callback-literal
  171:31  error  Expected error to be handled                      handle-callback-err
  286:7   error  Expected error to be handled                      handle-callback-err
  358:11  error  Expected error to be handled                      handle-callback-err
  372:14  error  Unexpected literal in error position of callback  standard/no-callback-literal

.../snippets/spec/body-parser-spec.js
   26:7   error  Unexpected template string expression  no-template-curly-in-string
   54:39  error  Unexpected template string expression  no-template-curly-in-string
   65:39  error  Unexpected template string expression  no-template-curly-in-string

   79:7   error  Unexpected template string expression  no-template-curly-in-string
  111:39  error  Unexpected template string expression  no-template-curly-in-string
  129:39  error  Unexpected template string expression  no-template-curly-in-string
  151:39  error  Unexpected template string expression  no-template-curly-in-string
  171:39  error  Unexpected template string expression  no-template-curly-in-string
  189:39  error  Unexpected template string expression  no-template-curly-in-string

.../snippets/spec/snippets-spec.js
    75:41  error  Unexpected template string expression  no-template-curly-in-string
   199:19  error  Unexpected template string expression  no-template-curly-in-string
   257:19  error  Unexpected template string expression  no-template-curly-in-string
   271:19  error  Unexpected template string expression  no-template-curly-in-string
   276:19  error  Unexpected template string expression  no-template-curly-in-string
   280:19  error  Unexpected template string expression  no-template-curly-in-string
   285:15  error  Unexpected template string expression  no-template-curly-in-string
   289:19  error  Unexpected template string expression  no-template-curly-in-string
   293:19  error  Unexpected template string expression  no-template-curly-in-string
   297:19  error  Unexpected template string expression  no-template-curly-in-string
   301:19  error  Unexpected template string expression  no-template-curly-in-string
  1335:23  error  Unexpected template string expression  no-template-curly-in-string
  1355:19  error  Unexpected template string expression  no-template-curly-in-string
  1360:19  error  Unexpected template string expression  no-template-curly-in-string
  1385:14  error  Unexpected template string expression  no-template-curly-in-string
  1397:14  error  Unexpected template string expression  no-template-curly-in-string
    @fluvf
    fluvf committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    4e658b3 View commit details
    Browse the repository at this point in the history