Fix missing props

atom · Nov 17, 2017 · 07299f6 · 07299f6
1 parent e733917
commit 07299f6
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/lib/popover-component.js b/lib/popover-component.js
@@ -21,24 +21,24 @@ class PopoverComponent {
 
   render () {
     const {
-      isClientOutdated, initializationError,
+      isClientOutdated, hasInitializationError,
       authenticationProvider, portalBindingManager,
       commandRegistry, credentialCache, clipboard, workspace
     } = this.props
 
     let activeComponent
-    if (isClientOutdated) {
+    if (isClientOutdated()) {
       if (!PackageOutdatedComponent) PackageOutdatedComponent = require('./package-outdated-component')
       activeComponent = $(PackageOutdatedComponent, {
         ref: 'packageOutdatedComponent',
         workspace
       })
-    } else if (initializationError) {
+    } else if (hasInitializationError()) {
       if (!PackageInitializationErrorComponent) PackageInitializationErrorComponent = require('./package-initialization-error-component')
       activeComponent = $(PackageInitializationErrorComponent, {
         ref: 'packageInitializationErrorComponent'
       })
-    } else if (this.props.authenticationProvider && this.props.authenticationProvider.isSignedIn()) {
+    } else if (authenticationProvider.isSignedIn()) {
       if (!PortalListComponent) PortalListComponent = require('./portal-list-component')
       activeComponent = $(PortalListComponent, {
         ref: 'portalListComponent',

diff --git a/lib/portal-status-bar-indicator.js b/lib/portal-status-bar-indicator.js
@@ -78,8 +78,8 @@ class PortalStatusBarIndicator {
 function buildElement (props) {
   const anchor = document.createElement('a')
   anchor.classList.add('PortalStatusBarIndicator', 'inline-block')
-  if (props.isClientOutdated) anchor.classList.add('outdated')
-  if (props.initializationError) anchor.classList.add('initialization-error')
+  if (props.isClientOutdated()) anchor.classList.add('outdated')
+  if (props.hasInitializationError()) anchor.classList.add('initialization-error')
 
   const icon = document.createElement('span')
   icon.classList.add('icon', 'icon-radio-tower')

diff --git a/lib/teletype-package.js b/lib/teletype-package.js
@@ -91,12 +91,15 @@ class TeletypePackage {
   async consumeStatusBar (statusBar) {
     const getPortalBindingManager = async () => await this.getPortalBindingManager()
     const getAuthenticationProvider = async () => await this.getAuthenticationProvider()
+    const isClientOutdated = () => this.isClientOutdated
+    const hasInitializationError = () => this.initializationError
     if (!PortalStatusBarIndicator) PortalStatusBarIndicator = require('./portal-status-bar-indicator')
     this.portalStatusBarIndicator = new PortalStatusBarIndicator({
       statusBar,
       getPortalBindingManager,
       getAuthenticationProvider,
-      isClientOutdated: this.isClientOutdated,
+      isClientOutdated,
+      hasInitializationError,
       tooltipManager: this.tooltipManager,
       commandRegistry: this.commandRegistry,
       clipboard: this.clipboard,