New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve nullptr handling #5984

Open

AndreyMlashkin wants to merge 2 commits into audacity:master from AndreyMlashkin:improve-nullptr-handling

AndreyMlashkin commented Feb 19, 2024 •

edited

This line only demonstrates the problem with a nullptr access. It fails on audacity start for me:
assert(pComputedItemContext && pRegistry);

I signed CLA
The title of the pull request describes an issue it addresses
If changes are extensive, then there is a sequence of easily reviewable commits
Each commit's message describes its purpose and effects
There are no behavior changes unnecessary for the stated purpose of the PR

Recommended:

Each commit compiles and runs on my machine without known undesirable changes of behavior

AndreyMlashkin added 2 commits

February 19, 2024 14:19


          add nullptr sanity checks

1ad95cb


          add nullptr assertion

a09ae71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment