-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin locations #6203
Plugin locations #6203
Conversation
54e4e05
to
19d1765
Compare
19d1765
to
43396a4
Compare
|
||
mRows->Add(rowSizer.release(), 0, wxEXPAND); | ||
|
||
if(setFocus) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that there's only one line after "if" statement but I'd add curly braces anyway - I've seen too many bugs with it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have a strict policy about use of brackets in if
-statements, but generally in Audacity's sources brackets are not used with single line expressions.
void AddLocations(const PluginPaths& paths) | ||
{ | ||
for(const auto& location : paths) | ||
AddLocation(location); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above - consider using curly braces anyway
One more commit added that fixed scrolled window auto-size issue |
4d5637c
to
ec41df0
Compare
ec41df0
to
69d84d8
Compare
Squashed fix commits |
e4d9b9f
to
38a614b
Compare
One new commit @vsverchinsky |
35a179e
to
7b3875c
Compare
Resolves: #6156
Recommended: