-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes mountpoint-s3-client support backpressure read #869
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monthonk
temporarily deployed
to
PR integration tests
May 7, 2024 10:09
— with
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
May 7, 2024 10:09
— with
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
May 7, 2024 10:09
— with
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
May 7, 2024 10:09
— with
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
May 7, 2024 10:09
— with
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
May 7, 2024 10:09
— with
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
May 7, 2024 10:09
— with
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
May 23, 2024 16:19
— with
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
May 23, 2024 16:19
— with
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
May 23, 2024 16:19
— with
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
May 23, 2024 16:19
— with
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
May 23, 2024 16:19
— with
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
May 23, 2024 16:19
— with
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
May 23, 2024 16:20
— with
GitHub Actions
Inactive
monthonk
requested a deployment
to
PR integration tests
May 24, 2024 10:21
— with
GitHub Actions
Waiting
monthonk
requested a deployment
to
PR integration tests
May 24, 2024 10:21
— with
GitHub Actions
Waiting
monthonk
requested a deployment
to
PR integration tests
May 24, 2024 10:21
— with
GitHub Actions
Waiting
monthonk
requested a deployment
to
PR integration tests
May 24, 2024 10:21
— with
GitHub Actions
Waiting
monthonk
requested a deployment
to
PR integration tests
May 24, 2024 10:21
— with
GitHub Actions
Waiting
monthonk
requested a deployment
to
PR integration tests
May 24, 2024 10:21
— with
GitHub Actions
Waiting
monthonk
requested a deployment
to
PR integration tests
May 24, 2024 10:21
— with
GitHub Actions
Waiting
Signed-off-by: Monthon Klongklaew <monthonk@amazon.com>
monthonk
temporarily deployed
to
PR integration tests
May 24, 2024 10:33
— with
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
May 24, 2024 10:33
— with
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
May 24, 2024 10:33
— with
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
May 24, 2024 10:33
— with
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
May 24, 2024 10:33
— with
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
May 24, 2024 10:33
— with
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
May 24, 2024 10:33
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The CRT has flow-control window feature in the read path (awslabs/aws-c-s3#213) to let users control how fast they want to download data. This change exposes the backpressure read mechanism in the
get_object
interface.Putting this into a draft to get early feedback.
Does this change impact existing behavior?
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).