[Babel 8] Bump commander to 12.1.0 #16517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57039 |
JLHwung
added
the
PR: Internal (next major) 🏠
| @@ -16,6 +16,7 @@ import type { PluginAPI, PluginObject } from "@babel/core"; | |||
|
|
|||
| const require = createRequire(import.meta.url); | |||
|
|
|||
| // @ts-expect-error TS2339: Property 'default' does not exist on type 'typeof import("./node_modules/commander-BABEL_8_BREAKING-true/typings/index")' | |||
| const program = commander.default.program as commander.Command; | |||
There was a problem hiding this comment.
Can we maybe add this to lib/third-party-libs.d.ts?
declare module "commander" {
import type { Command } from "commander-BABEL_8_BREAKING-true";
const _default: { program: Command };
export { _default as default };
}(and remove it from tsconfig's paths)
JLHwung
force-pushed
the
bump-commander-babel-8
branch
from
b4f99bf
to
bee836b
Compare
liuxingbaoyu
approved these changes
May 26, 2024
nicolo-ribaudo
approved these changes
May 27, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commander 12.1.0 supports Node.js 18 and above, so it is safe to bump it for Babel 8.