Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-POSIX text editor file paths for Windows. #5142

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sgunn80808
Copy link

@sgunn80808 sgunn80808 commented Mar 11, 2024

Description

Fixes issue with shlex.split parsing Windows editor program file paths as POSIX.

This resulted in the following error for a program located in C:\Program Files when running beet edit

error: could not run editor command 'C:Program': [WinError 2] The system cannot find the file specified

Setting posix = not is_windows changes the default parsing mode of shlex for Windows platform and allows Windows file paths to be used to specify the text editor.

To Do

  • Documentation
  • Changelog
  • Tests

@sgunn80808
Copy link
Author

I marked Tests as non-mandatory because I couldn't find a good place to add a test for this change. Please comment here if you have any suggestions for where a test should go and I can add one. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant