-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change: Change websocket lib to graphql-ws #20282
Change: Change websocket lib to graphql-ws #20282
Conversation
After conducting some tests, I found that migrating to
Aside from these changes, the overall structure remains the same. More details at: |
This pull request has conflicts ☹ |
@@ -1,12 +1,12 @@ | |||
import { | |||
ApolloClient, ApolloProvider, InMemoryCache, NormalizedCacheObject, ApolloLink, | |||
} from '@apollo/client'; | |||
import { WebSocketLink } from '@apollo/client/link/ws'; | |||
import { SubscriptionClient } from 'subscriptions-transport-ws'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be removed from package.json
?
…uebutton into change-graphql-websocket
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Automated tests Summary✅ All the CI tests have passed! |
1aab2f5
into
bigbluebutton:v3.0.x-release
What does this PR do?
It changes to a better supported library graphql-ws
One of the main reasons of this decision is that our old library was deprecated
https://github.com/apollographql/subscriptions-transport-ws