releases: use LLVM 18 for macOS #30022
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
| else | ||
| $(package)_file_name=clang+llvm-$($(package)_version)-x86_64-linux-gnu-ubuntu-22.04.tar.xz | ||
| $(package)_sha256_hash=884ee67d647d77e58740c1e645649e29ae9e8a6fe87c1376be0f3a30f3cc9ab3 | ||
| $(package)_file_name=clang+llvm-$($(package)_version)-x86_64-linux-gnu-ubuntu-18.04.tar.xz |
There was a problem hiding this comment.
this download link works but ubuntu-18?
There was a problem hiding this comment.
this download link works but ubuntu-18?
This should be fixed in LLVM 19: https://discourse.llvm.org/t/rfc-improve-binary-security/78121/56
There was a problem hiding this comment.
Yea. While using the pre-built bins, we have to take what is available. For some reason the person building the x86_64 bins here has reverted to that. It also means we'll need to revert to installing libtinfo5 in the macOS CI, which is also annoying, because you also can't actually install that on Ubuntu 24.04 (although we currently still use 22.04 here, so it'll work for now).
There was a problem hiding this comment.
Or waiting after #21778, which should be fine as well, as there is no rush to use clang 18?
fanquake
force-pushed
the
macos_llvm_18_releases
branch
from
857130c
to
6170706
Compare
fanquake
force-pushed
the
macos_llvm_18_releases
branch
from
6170706
to
1246dfc
Compare
Not supported by llvm-ar / llvm-ranlib.
Adjust the security check for: ld64.lld: warning: Option `-allow_stack_execute' is not yet implemented. ld64.lld: error: -fixup_chains is incompatible with -no_pie and to account for the embedding of LLVMs version number.
LLD enables ZERO_AR_DATE by default, setting it to zero would enable non-determinism, setting it to any other value is ignored. See: https://github.com/llvm/llvm-project/blob/main/lld/docs/MachO/ld64-vs-lld.rst.
Includes LLVM 18.1.4
Patch Qts internal libpng to resolve the failure.
Version is 18.1.4.
fanquake
force-pushed
the
macos_llvm_18_releases
branch
from
1246dfc
to
0b01a0f
Compare
Bumps the Guix time-machine to include a bump to LLVM 18.1.4: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=837016fe33e11c6252ec24c423d1b6ae0cd7efd3. Can split this out given it effects all releases.
Needs another patch to Qt. It's internal libpng build is broken with the newer Clang, due to:
See https://releases.llvm.org/18.1.0/tools/clang/docs/ReleaseNotes.html?1=#clang-frontend-potentially-breaking-changes.