Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Roll clang in test-each-commit task #30060

Merged
merged 2 commits into from May 15, 2024
Merged

ci: Roll clang in test-each-commit task #30060

merged 2 commits into from May 15, 2024

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented May 8, 2024

Needed for #29077 (comment)

@DrahtBot
Copy link
Contributor

DrahtBot commented May 8, 2024 •
edited

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK fanquake, hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #30043 (net: Replace libnatpmp with built-in PCP implementation by laanwj)
  • #29432 (Stratum v2 Template Provider (take 3) by Sjors)
  • #29274 (Support self-hosted Cirrus workers on forks by Sjors)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@DrahtBot DrahtBot added the Tests label May 8, 2024
fanquake
fanquake approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2094da6

@maflcko
Copy link
Member Author

maflcko commented May 8, 2024

This fails, because the image does not exist yet.

@fanquake
Copy link
Member

fanquake commented May 8, 2024

Yea, don't have to merge, but can do as soon as we have green CI. The image should be available very shortly?

@maflcko maflcko mentioned this pull request May 8, 2024
Closed
This was referenced May 8, 2024
Open
Draft
Open
hebasto
hebasto approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2094da6.

This fails, because the image does not exist yet.

I've re-run the CI job.

@maflcko maflcko marked this pull request as ready for review May 15, 2024 07:53
@maflcko
Copy link
Member Author

maflcko commented May 15, 2024

rebased to fix commit hashes 🙈

hebasto
hebasto approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ACK fa90ad2.

@fanquake fanquake merged commit 42d5a1f into bitcoin:master May 15, 2024
7 of 16 checks passed
@maflcko maflcko deleted the 2405-ci-clang-roll branch May 15, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanquake fanquake fanquake approved these changes

@hebasto hebasto hebasto approved these changes

@mouhand999 mouhand999 mouhand999 approved these changes

Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@maflcko @DrahtBot @fanquake @hebasto @mouhand999