Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init: fixes file descriptor accounting #30065

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on May 24, 2024

  1. init: fixes fd accounting regarding poll/select

    We are computing our file descriptors limits based on whether we use
    poll or select. However, we are taking that into account only partially
    (subtracting from fd_max in one case, but from nFD later on). Moreover,
    nBind is also only accounted for partially.
    
    Simplify and fix this logic
    sr-gi committed May 24, 2024
    Configuration menu
    Copy the full SHA
    e09dded View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. init: improves file descriptors accounting and docs

    The current logic for file descriptor accounting is pretty convoluted and hard
    to follow. This is partially caused by the lack of documentation plus non-intuitive
    variable naming (which was more intuitive when fewer things were accounted for, but
    hasn't aged well). This has led to this accounting being error-prone and hard to maintain
    (as shown in he previous commit).
    
    Redefine some of the constants, plus document what are we accounting for so this can be
    extended more easily
    
    Remove FreeBSD workaround to bitcoin#2695
    sr-gi committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    0a7030d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fe76929 View commit details
    Browse the repository at this point in the history