Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Coin Wallet to wallets sections #438

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nikashitsa
Copy link
Contributor

This PR adds Coin Wallet to wallets sections with better resolution logo.

Coin Wallet still works and alive.
Already listed at bitcoin.org (android, ios, web)

@nikashitsa nikashitsa requested review from Mengerian and merc1er and removed request for Mengerian January 15, 2020 05:41
Copy link
Contributor

@merc1er merc1er left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested the wallet and found the following:

  • does not support 0-conf
  • the fees are way too high (I sent myself 10 cents and I was asked to pay a 20 cent fee to send the funds back)
  • the 'max' function doesn't seem to work

Other than this, the experience was good and it's nice not to have to install anything and be able to use BCH in the browser :)

@nikashitsa
Copy link
Contributor Author

@merc1er please have look at last version (v2.17.0) 👀
Now it supports 0-conf, 'max' function is fixed and fee is much lower for BCH.

@merc1er
Copy link
Contributor

merc1er commented Feb 14, 2020

Fee still is about 10 times the BCH network fee.
The 'max' button doesn't work on my end (see screenshot).

IMG_6027

@nikashitsa
Copy link
Contributor Author

nikashitsa commented Feb 14, 2020

Ok. Now I set 1 sat/byte for fee (10 sat/byte was before).
The "Max" button shown you 0 because 0.00002054 - 0.0000226 (fee) = -0.00000206.
Now all should work fine (just refresh your page). Perhaps, later we will add dynamic fees for BCH also.

@merc1er merc1er self-requested a review February 15, 2020 05:50
@nikashitsa
Copy link
Contributor Author

@merc1er how it's going? Meanwhile, we've added desktop apps for all platforms (Windows, macOS, Linux).

@merc1er
Copy link
Contributor

merc1er commented Jun 9, 2020

I reviewed the web wallet and iOS app and I really enjoyed the user experience!!! Fast and easy.

@merc1er
Copy link
Contributor

merc1er commented Jun 9, 2020

@Mengerian @jasonbcox what do you think? Do you want to try the Android and Windows versions? (I don't have any of these OS with me)

I'm thinking this web wallet would be ideal to show people BCH without having to download anything on their phone during meetups for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants