Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove country flags for languages. #50

Closed
wants to merge 1 commit into from
Closed

Remove country flags for languages. #50

wants to merge 1 commit into from

Conversation

kbsezginel
Copy link

@kbsezginel kbsezginel commented Feb 17, 2018

@chaintip fixes #48

@chaintip
Copy link

If this pull request is merged to fix issue #48 first, @kbsezginel will claim the 0.00879166 BCH| ~ 13.55 USD bounty and all future tips to the issue.

@dagurval
Copy link
Member

dagurval commented Feb 17, 2018

Thanks for working on this.

When you just remove the flags, what's left is just random letters with awkward padding. It's even harder to tell that it's for language selection, so not really an improvement.

lang

Issue #48 suggests an alternative:

Suggest replacing it with the name of the language, in the language itself, like bitcoincash.org does.

Other solutions are also welcomed.

@dannyOhNo
Copy link

Alternative solution submitted here: #53

@dagurval
Copy link
Member

This won't go in, but I appreciate the PR @kbsezginel @chaintip

@chaintip
Copy link

@kbsezginel, you've been sent 0.006736 BCH| ~ 10.18 USD by @dagurval via chaintip.

@dgenr8
Copy link
Member

dgenr8 commented Feb 19, 2018

Closing in favor of #54

@dgenr8 dgenr8 closed this Feb 19, 2018
@kbsezginel
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove country flags
5 participants