cleanup

bitpay · May 3, 2024 · 08f4871 · 08f4871
1 parent a6d51cf
commit 08f4871
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 17 deletions.
diff --git a/packages/bitcore-node/src/providers/chain-state/evm/api/ecsp.ts b/packages/bitcore-node/src/providers/chain-state/evm/api/ecsp.ts
@@ -152,17 +152,6 @@ export class BaseEVMExternalStateProvider extends InternalStateProvider implemen
     return undefined;
   }
 
-  async streamBlocks(_params: StreamBlocksParams) {
-    try {
-      // open and write to a stream while searching for multiple blocks by date
-      // limit 10
-      throw new Error('Method not implemented.');
-    } catch (err) {
-      logger.error('Error streaming blocks from historical node %o', err);
-      throw err;
-    }
-  }
-
   async getTransaction(params: StreamTransactionParams) {
     try {
       let { chain, network, txId } = params;
@@ -208,9 +197,6 @@ export class BaseEVMExternalStateProvider extends InternalStateProvider implemen
       if (blockHeight !== undefined) {
         blockHeight = Number(blockHeight);
       }
-      if (blockHash !== undefined) {
-        blockHash = blockHash;
-      }
       // get block tip for confirmations
       const tip = await this.getLocalTip(params);
       const tipHeight = tip ? tip.height : 0;

diff --git a/packages/bitcore-wallet-service/src/lib/errors/errordefinitions.ts b/packages/bitcore-wallet-service/src/lib/errors/errordefinitions.ts
@@ -15,23 +15,25 @@ interface Errors<T> {
   ONLY_CASHADDR: T;
   INSUFFICIENT_FUNDS: T;
   INSUFFICIENT_FUNDS_FOR_FEE: T;
-
   INVALID_ADDRESS: T;
   INVALID_CHANGE_ADDRESS: T;
   KEY_IN_COPAYER: T;
   LOCKED_FUNDS: T;
-
+  // Polygon Errors
   INSUFFICIENT_MATIC_FEE: T;
   LOCKED_MATIC_FEE: T;
+  // Ethereum Errors
   INSUFFICIENT_ETH_FEE: T;
   LOCKED_ETH_FEE: T;
+  // Arbitrum Errors
   INSUFFICIENT_ARB_FEE: T;
   LOCKED_ARB_FEE: T;
+  // Base Errors
   INSUFFICIENT_BASE_FEE: T;
   LOCKED_BASE_FEE: T;
+  // Optimisim Errors
   INSUFFICIENT_OP_FEE: T;
   LOCKED_OP_FEE: T;
-
   HISTORY_LIMIT_EXCEEDED: T;
   MAIN_ADDRESS_GAP_REACHED: T;
   NETWORK_SUSPENDED: T;