Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed dup check in address test #3247

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Removed dup check in address test #3247

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
048fa4c
Removed dup check in address test
lukerhoads Aug 18, 2021
3a6605d
Merge branch 'bitpay:master' into remove-dup-address-test
lukerhoads Aug 19, 2021
a34e501
Update LTC default fee levels
kajoseph Jul 30, 2021
20d12a5
Copy n paste whoes
kajoseph Jul 30, 2021
dbc193b
Removed dup check in address test
lukerhoads Aug 18, 2021
5f28c5e
[FIX] XRP tx create
gabrielbazan7 Aug 18, 2021
50a5c03
Merge branch 'remove-dup-address-test' of https://github.com/lukerhoa…
lukerhoads Aug 19, 2021
a73c518
Fix address questions dup
lukerhoads Aug 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 4 additions & 5 deletions packages/bitcore-lib/test/address.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,6 @@ describe('Address', function() {
it('should make an address from a buffer', function() {
Address.fromBuffer(buf).toString().should.equal(str);
new Address(buf).toString().should.equal(str);
new Address(buf).toString().should.equal(str);
});

it('should make an address from a string', function() {
Expand Down Expand Up @@ -509,14 +508,14 @@ describe('Address', function() {
it('should detect a P2SH address', function() {
new Address(P2SHLivenet[0]).isPayToScriptHash().should.equal(true);
new Address(P2SHLivenet[0]).isPayToPublicKeyHash().should.equal(false);
new Address(P2SHTestnet[0]).isPayToScriptHash().should.equal(true);
new Address(P2SHTestnet[0]).isPayToPublicKeyHash().should.equal(false);
new Address(P2SHTestnet[0]).isPayToWitnessScriptHash().should.equal(false);
new Address(P2SHTestnet[0]).isPayToWitnessPublicKeyHash().should.equal(false);
});
it('should detect a Pay To PubkeyHash address', function() {
new Address(PKHLivenet[0]).isPayToPublicKeyHash().should.equal(true);
new Address(PKHLivenet[0]).isPayToScriptHash().should.equal(false);
new Address(PKHTestnet[0]).isPayToPublicKeyHash().should.equal(true);
new Address(PKHTestnet[0]).isPayToScriptHash().should.equal(false);
new Address(PKHTestnet[0]).isPayToWitnessScriptHash().should.equal(false);
new Address(PKHTestnet[0]).isPayToWitnessPublicKeyHash().should.equal(false);
});
});

Expand Down