Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bitcore] Support Arb, Base, and Op Chains #3726

Merged
merged 15 commits into from
May 9, 2024
Merged

[Bitcore] Support Arb, Base, and Op Chains #3726

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
5bb33c7
add ARB, BASE, and OP support to CWC and BWS
leolambo Apr 16, 2024
3d2c5ca
add streaming support to externally provided historical chain state
leolambo Apr 24, 2024
30a2bf8
add axios
leolambo Apr 24, 2024
dcd4fa0
update imports
leolambo Apr 24, 2024
9114b1b
feedback
leolambo Apr 25, 2024
3f792c6
add nodeStreams
leolambo Apr 26, 2024
956bea0
feedback
leolambo Apr 30, 2024
1d3760f
lint
leolambo May 1, 2024
3cc4890
Merge branch 'master' of https://github.com/bitpay/bitcore into evmCh…
leolambo May 1, 2024
61ecd25
fix tests
leolambo May 1, 2024
f3f49dc
update package.json
leolambo May 1, 2024
32c3bb6
get chain from coin
leolambo May 1, 2024
a6d51cf
await transaction stream
leolambo May 3, 2024
08f4871
cleanup
leolambo May 3, 2024
5546c80
fix legacy credentials test
leolambo May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/bitcore-client/bin/wallet-token
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const main = async () => {
const { name, path, contractAddress, storageType, tokenName } = program.opts();
try {
wallet = await Wallet.loadWallet({ name, path, storageType });
if (!['MATIC', 'ETH'].includes(wallet.chain)) {
if (!['MATIC', 'ETH', 'ARB', 'OP', 'BASE'].includes(wallet.chain)) {
throw new Error('Cannot add token to non-ETH wallet.');
}
const token = await wallet.getToken(contractAddress);
Expand Down
3 changes: 3 additions & 0 deletions packages/bitcore-client/src/wallet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ const chainLibs = {
LTC: BitcoreLibLtc,
ETH: { Web3, ethers },
MATIC: { Web3, ethers },
ARB: { Web3, ethers },
BASE: { Web3, ethers },
OP: { Web3, ethers },
XRP: xrpl
};

Expand Down