SP-943 Python SDK should handle scientific notation #111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As reported by DorskFR on #110, we can sometimes have values for
paymentTotals.*
andpaymentSubtotals.*
can come back as scientific notation, for example:Scientific notation values such as
1.321044547e+21
while uncommon are valid in JSON per ECMA-404:The number
1.321044547e+21
is valid Python as well, however it is too large for anint
, so we need to define these fields as aDecimal
type from thedecimal
library.Changes
decimal
libraryDecimal
type instead ofint
Notes
Testing shows that this is not required for 5.0.x as these were being defined as
None
.