Issue #561: [HitBTC] OrderBook is missing support of timestamp #563
Conversation
...eam-hitbtc/src/main/java/info/bitrich/xchangestream/hitbtc/dto/HitbtcWebSocketOrderBook.java
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,40 @@ | |||
| package info.bitrich.xchangestream.hitbtc.dto; | |||
There was a problem hiding this comment.
I can't see how this is being used. I'd expect to see a corresponding change in https://github.com/bitrich-info/xchange-stream/blob/develop/xchange-stream-hitbtc/src/main/java/info/bitrich/xchangestream/hitbtc/HitbtcStreamingMarketDataService.java to feed the timestamp to clients?
There was a problem hiding this comment.
Locally, I extended HitbtcAdapters.adaptOrderBook method from the org.knowm.xchange library to support timestamps. However, ideally, it should be updated at the source library, rather than "overridden" here. Having said that, I'm fine to commit it as well if it does make sense.
|
Thanksfor your contribution @dp770! Just a couple of thoughts/questions. |
…stamp. Using built-in date time formatter with UTC timezone.
…stamp. Using built-in date time formatter with UTC timezone.
…stamp. Using built-in date time formatter with UTC timezone.
…rt_in_orderbook' into HitBTC_timestamp_attribute_support_in_orderbook
|
This project is in the process of being merged into the XChange project and no further PRs will be merged here. Once the projects have been merged, there may be a short stabilization period where there will be large-scale renaming of classes and packages, which may cause conflicts. You are advised to wait at least a week from now and then resubmit your PR on the XChange project. Thank you for your support! |
|
You can now resubmit your PR on XChange. This project will shortly be marked as archived. |
Timestamp attribute is added to HitbtcOrderBookWithTimestamp (extension of HitbtcOrderBook)