Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-7737] Create about-page and more-from-bitwarden page [Nav changes] #9233

Merged
merged 23 commits into from
May 22, 2024

Conversation

djsmith85
Copy link
Contributor

@djsmith85 djsmith85 commented May 17, 2024

Type of change

- [ ] Bug fix
- [X] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

In preparation for the extension UI refresh this moves some settings-item to different pages.

The actual UI update changes will be done in a follow-up PR under a feature-flag

Code changes

Settings-page

About-Page

  • Move help-and-feedback to tools and rename to about-page - 4a262c4
    • Moved help-and-feedback.component to ..tools
    • Renamed it to about-page
    • Changed the title to about
    • Changed the settings button to about
    • Updated routes
    • Updates transition animation
  • Move button to open AboutDialog from settings to about-page - c47f580
  • Move launch web-vault to about-page - 89d2cc7
  • Move rate extension from settings to about-page - af8116d
  • Fix no-floating-promises - 79231a5
  • Remove icons from about-page entries - 5c5e9bb
  • Make about-page standalone - d8efe1e
  • Add new speedbumps to help-center and web-app links - 8d7ee56
  • Add popout-button to about-page - 37315b7

More From Bitwarden-page

  • Create MoreFromBitwardenPage component - 27a6925
    • Create new component
    • Add button to navigate to new component from about-page
    • Add routing for new component
  • Add link to Bitwarden Authenticator page - 70286b8
    • Include speedbump explaing some functionality about the the authenticator
  • Add link to Secrets Manager page - 8c79c75
    • Include speedbump explaining some functionality of Secrets Manager
  • Add link to Passwordless.dev page - 96ab912
    • Include speedbump explaining some functionality of Passwordless.dev
  • Move learnFromOrg over to more-from-bitwarden - 6616a0a
    • Include speedbump that explains Bitwarden for business
  • Move premium-link to more-from-bitwarden - 93826a8
    • Hide link if user already has premium
  • Add Free Bitwarden Families link - 837ad20
    • Include speedbump explaining Free Bitwarden Families

Screenshots

Before

before_settings1
before_settings2

After

Settings-page

after_settings

About-page

after_aboutPage
after__speedbump_helpCenter
after_speedbump_webApp

More from Bitwarden-page

after_speedbump_freeFamilies
after_speedbump_BitwardenForBusiness
after_speedbump_authenticator
after_speedbump_secretsManager
after_speedbump_passwordless

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

Moved help-and-feedback.component to ..tools
Renamed it to about-page
Changed the title to about
Changed the settings button to about
Updated routes
Updates transition animation
Create new component
Add button to navigate to new component from about-page
Add routing for new component
Include speedbump explaing some functionality about the the authenticator
Include speedbump explaining some functionality of Secrets Manager
Include speedbump explaining some functionality of Passwordless.dev
Include speedbump that explains Bitwarden for business
Some left-over clean-up from #8840
- Removing import and export methods
Hide link if user already has premium
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 66 lines in your changes are missing coverage. Please review.

Project coverage is 28.13%. Comparing base (594a6f1) to head (0cb58aa).
Report is 1 commits behind head on main.

Current head 0cb58aa differs from pull request most recent head 01a3c6d

Please upload reports for the commit 01a3c6d to get more accurate results.

Files Patch % Lines
...s/about-page/more-from-bitwarden-page.component.ts 0.00% 32 Missing ⚠️
.../popup/settings/about-page/about-page.component.ts 0.00% 30 Missing ⚠️
apps/browser/src/popup/app-routing.module.ts 0.00% 2 Missing ⚠️
...ser/src/tools/popup/settings/settings.component.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9233      +/-   ##
==========================================
- Coverage   28.13%   28.13%   -0.01%     
==========================================
  Files        2369     2370       +1     
  Lines       70056    70041      -15     
  Branches    13163    13161       -2     
==========================================
- Hits        19713    19704       -9     
+ Misses      48783    48778       -5     
+ Partials     1560     1559       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djsmith85 djsmith85 marked this pull request as ready for review May 17, 2024 10:23
@djsmith85 djsmith85 requested a review from a team as a code owner May 17, 2024 10:23
Copy link
Contributor

github-actions bot commented May 17, 2024

Logo
Checkmarx One – Scan Summary & Detailsc9d963e4-5fa6-4a9e-a02d-0a2c63b1a3bb

No New Or Fixed Issues Found

Include speedbump explaining Free Bitwarden Families
Copy link
Contributor

@aj-rosado aj-rosado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djsmith85 djsmith85 removed the needs-qa Marks a PR as requiring QA approval label May 22, 2024
@djsmith85 djsmith85 enabled auto-merge (squash) May 22, 2024 17:00
@djsmith85 djsmith85 merged commit d6f78f2 into main May 22, 2024
17 checks passed
@djsmith85 djsmith85 deleted the tools/pm-7737/create-about-page-nav-changes branch May 22, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants