fix(scss): invalid max-height CSS value, and SCSS selector typo #7169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
We operate a site that must adhere to strict W3C Accessibility Standards.
When running one of our pages through the W3C Markup Validation Service to test Priority A compliance, our external auditor received the following CSS errors that could affect our accreditation:
max-height: auto
is not amax-height
value. (appears twice)output-width
: Propertyoutput-width
doesn't exist.I've replaced
max-height: auto
withmax-height: 100%
and removed an incorrectly placed colon in the SCSS, as this spawns the invalidoutput-width
property when it's transpiled into CSS.A workaround for us currently is to host the SCSS files in our project, using XCOPY to copy the SCSS files from this repo, making the fixes there. This isn't ideal.
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)
, requires a patch version updatefeat(...)
, requires a minor version updatefeat(...)
, requires a minor version updatefix(...)
, requires a patch or minor version updatechore(docs)
, requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc.). This is very important, as theCHANGELOG
is generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: