Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Reopen addrepowindow prefilled when adding repo fails #1966

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shivansh02
Copy link
Collaborator

@shivansh02 shivansh02 commented Mar 13, 2024

Description

The addRepoWindow now opens prefilled with RepoUrl, name and extraBorgArguments if adding repo fails.
Does not save password due to security reasons, and Encryption because last saved value might no longer be supported on next run of vorta (in case user changes Borg version).

Related Issue

Resolves #1757

Motivation and Context

Add Repo Window does not retain last inputs when adding the repo fails and needs to be filled again.

How Has This Been Tested?

Tested locally by making process_result method of BorgInitJob raise an error intentionally, to mimic failure in adding repo.

Screenshots (if appropriate):

Adding new Repo (which fails):
Screenshot from 2024-03-13 19-23-00
Screenshot from 2024-03-13 19-23-07
AddRepoWindow opens prefilled next time:
Screenshot from 2024-03-13 19-23-19
Screenshot from 2024-03-13 19-23-26

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reopen AddRepoWindow prefilled on failure.
1 participant