Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dependencies to be installed in 32 bits bottle #3101

Merged
merged 5 commits into from
Nov 30, 2023

Conversation

koplo199
Copy link
Contributor

Superseed #3058, thanks to Kinsteen for his work on this!

Fixes #2918
Fixes #2166

@fab-sonarqube
Copy link

fab-sonarqube bot commented Sep 27, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023

Pylint result on modfied files:
************* Module bottles.frontend.views.bottle_dependencies
bottles/frontend/views/bottle_dependencies.py:21:0: E0611: No name 'Adw' in module 'gi.repository' (no-name-in-module)
************* Module bottles.frontend.widgets.dependency
bottles/frontend/widgets/dependency.py:22:0: E0611: No name 'Adw' in module 'gi.repository' (no-name-in-module)
bottles/frontend/widgets/dependency.py:59:12: W0105: String statement has no effect (pointless-string-statement)
bottles/frontend/widgets/dependency.py:90:12: W0105: String statement has no effect (pointless-string-statement)
bottles/frontend/widgets/dependency.py:99:12: W0105: String statement has no effect (pointless-string-statement)
bottles/frontend/widgets/dependency.py:166:49: W0613: Unused argument 'error' (unused-argument)
************* Module bottles.backend.managers.dependency
bottles/backend/managers/dependency.py:84:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:102:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:113:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:127:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:146:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:163:12: W0105: String statement has no effect (pointless-string-statement)

Copy link

fab-sonarqube bot commented Nov 30, 2023

@mirkobrombin mirkobrombin merged commit 065c66a into bottlesdevs:main Nov 30, 2023
6 checks passed
@koplo199 koplo199 deleted the 32bits-dependencies branch March 26, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants