Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(general): TF and ARM - Ensure that Databricks Workspaces enable… #6313

Merged
merged 1 commit into from
May 23, 2024

Conversation

MrTomerLevi
Copy link
Contributor

@MrTomerLevi MrTomerLevi commented May 16, 2024

Ensure that Azure Databricks Workspaces enables customer-managed key for root DBFS encryption

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Ensure that Azure Databricks Workspaces enables customer-managed key for root DBFS encryption.

Fixes # (issue)

New policies

CKV2_AZURE_48

Description

This policy ensure that the root DBFS (Databricks File System) associated with Databricks Workspace is encrypted using a customer-managed key rather than the default Azure key.

https://learn.microsoft.com/en-us/azure/databricks/security/keys/customer-managed-keys-dbfs/
https://github.com/Azure/azure-quickstart-templates/blob/master/quickstarts/microsoft.databricks/databricks-workspace-with-dbfs-root-customer-managed-keys/azuredeploy.json

Fix

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@MrTomerLevi MrTomerLevi changed the title feat(general) - TF and ARM - Ensure that Databricks Workspaces enable… feat(general): TF and ARM - Ensure that Databricks Workspaces enable… May 16, 2024
@MrTomerLevi MrTomerLevi force-pushed the feat/azure-databricks-workspaces-root-encryption branch from e1e422b to ec4cdf6 Compare May 16, 2024 12:12
from checkov.arm.base_resource_check import BaseResourceCheck
from checkov.common.util.data_structures_utils import find_in_dict

# https://learn.microsoft.com/en-us/azure/templates/microsoft.databricks/workspaces?pivots=deployment-language-arm-template#workspaceencryptionparameter-1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add it as a documentation of the class?

…s customer-managed key for root DBFS encryption
@MrTomerLevi MrTomerLevi force-pushed the feat/azure-databricks-workspaces-root-encryption branch from ec4cdf6 to 5ee7570 Compare May 19, 2024 03:00
Copy link
Contributor

@SteveVaknin SteveVaknin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first contribution 🏆

@MrTomerLevi MrTomerLevi merged commit a6b9e98 into main May 23, 2024
41 checks passed
@MrTomerLevi MrTomerLevi deleted the feat/azure-databricks-workspaces-root-encryption branch May 23, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants